Skip to content

[BCI-3989][solana] - CR methods err when service unstarted #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 29 commits into
base: develop
Choose a base branch
from
Draft

[BCI-3989][solana] - CR methods err when service unstarted #829

wants to merge 29 commits into from

Conversation

Farber98
Copy link
Contributor

@Farber98 Farber98 commented Aug 22, 2024 •
edited
Loading

Task Description:

CR methods should throw an error if service is unstarted

This PR:

  • Adds Close method enforced in the chainReaderInterfaceTester.

Ticket:

Depends on:

@Farber98 Farber98 mentioned this pull request Aug 22, 2024
Draft
@Farber98 Farber98 force-pushed the BCI-3989-cr-methods-error-when-unstarted branch from 2e4b2f2 to e4b1032 Compare August 22, 2024 14:09
@Farber98 Farber98 marked this pull request as ready for review August 23, 2024 12:06
@Farber98 Farber98 requested a review from a team as a code owner August 23, 2024 12:06
@Farber98 Farber98 self-assigned this Aug 23, 2024
ilija42
ilija42 previously approved these changes Aug 26, 2024
View reviewed changes
jmank88
jmank88 previously approved these changes Aug 29, 2024
View reviewed changes
@Farber98 Farber98 marked this pull request as ready for review September 13, 2024 11:15
@Farber98 Farber98 marked this pull request as draft September 13, 2024 22:46
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmank88 jmank88 jmank88 requested changes

@ilija42 ilija42 ilija42 left review comments

@aalu1418 aalu1418 aalu1418 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Farber98 Farber98

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Farber98 @jmank88 @aalu1418 @ilija42